On Wednesday, February 12, 2014 10:01:06 AM [email protected] wrote:
> From: Dirk Brandewie <[email protected]>
> 
> Using LFM ratio provides better perf/watt vs min ratio.
> 
> Signed-off-by: Dirk Brandewie <[email protected]>

This changelog is particularly insufficient.

Can you please explain what's wrong with the previous calculation and how
the change makes it better?

> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b80c03d..ff45ce1 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -356,7 +356,7 @@ static int byt_get_min_pstate(void)
>  {
>       u64 value;
>       rdmsrl(BYT_RATIOS, value);
> -     return value & 0xFF;
> +     return (value >> 8) & 0xFF;
>  }
>  
>  static int byt_get_max_pstate(void)
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to