On Tue, Feb 18, 2014 at 01:56:44PM +0100, Jiri Olsa wrote: > On Mon, Feb 10, 2014 at 12:29:00PM -0500, Don Zickus wrote: > > When printing the raw dump of a data file, the header.misc is > > printed as a decimal. Unfortunately, that field is a bit mask, so > > it is hard to interpret as a decimal. > > > > Print in hex, so the user can easily see what bits are set and more > > importantly what type of info it is conveying. > > > > Signed-off-by: Don Zickus <[email protected]> > > --- > > tools/perf/util/session.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > > index 0b39a48..d1ad10f 100644 > > --- a/tools/perf/util/session.c > > +++ b/tools/perf/util/session.c > > @@ -793,7 +793,7 @@ static void dump_sample(struct perf_evsel *evsel, union > > perf_event *event, > > if (!dump_trace) > > return; > > > > - printf("(IP, %d): %d/%d: %#" PRIx64 " period: %" PRIu64 " addr: %#" > > PRIx64 "\n", > > + printf("(IP, %x): %d/%d: %#" PRIx64 " period: %" PRIu64 " addr: %#" > > PRIx64 "\n", > > event->header.misc, sample->pid, sample->tid, sample->ip, > > sample->period, sample->addr); > > nit, maybe use '0x%x' ? hum, but probably nobody is actually parsing this..
Fair enough. :-) Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
