Hi Hemant, On Tue, 25 Feb 2014 14:33:37 +0530, Hemant Kumar wrote: > On 02/25/2014 12:26 PM, Namhyung Kim wrote: >>> + /* Translation from file representation to memory representation */ >>> + if (gelf_xlatetom(*elf, &dst, &src, >>> + elf_getident(*elf, NULL)[EI_DATA]) == NULL) >> Do we really need this xlate function? It seems elf_getdata() already >> did necessary conversions so only thing we need to do is checking its >> class and read out the addresses in a proper length, no? >> > > Hmm, alright. I thought the conversion was necessary for cross > developed binaries. > But I guess elf_getdata() should do all these conversions. Will remove that.
Looking at the source, it seems we still need to xlate() anyway. The conversion function (elf_cvt_note) only handles the header part since it cannot know what the content is. But obviously we cannot enable/disable the marker as we cannot run the cross-built binary - it only can be used to show the list of SDT markers in the binary. Or else, we can simply deny to do it.. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
