On Wed, 2 Feb 2005 12:12:38 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote:
29_ide_explicit_TASKFILE_NO_DATA.patch
Make data_phase explicit in NO_DATA cases.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Index: linux-ide-export/drivers/ide/ide-disk.c =================================================================== --- linux-ide-export.orig/drivers/ide/ide-disk.c 2005-02-02 10:28:07.852771465 +0900 +++ linux-ide-export/drivers/ide/ide-disk.c 2005-02-02 10:28:08.121727827 +0900 @@ -300,6 +300,7 @@ static unsigned long idedisk_read_native args.tfRegister[IDE_SELECT_OFFSET] = 0x40; args.tfRegister[IDE_COMMAND_OFFSET] = WIN_READ_NATIVE_MAX; args.command_type = IDE_DRIVE_TASK_NO_DATA; + args.data_phase = TASKFILE_NO_DATA; args.handler = &task_no_data_intr;
Could you add small helper to ide.h for doing this?
static inline void ide_prep_no_data_cmd(ide_task_t *task) { task->command_type = IDE_DRIVE_TASK_NO_DATA; task->data_phase = TASKFILE_NO_DATA; task->handler = &task_no_data_intr; }
I am thinking about removing task->handler initialization. Such that it defaults to task_no_data_intr if data_phase == TASKFILE_NO_DATA and so on for all other data_phases. Currently, the same information is specified repeatedly. What do you think?
Also please move this patch earlier in the series so I can merge it quickly.
Thanks.
Sure.
-- tejun
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
