On Fri, 2014-02-28 at 10:12 +0000, Russell King - ARM Linux wrote: > On Mon, Feb 10, 2014 at 02:38:58AM -0500, David Long wrote: > > diff --git a/arch/arm/kernel/probes.c b/arch/arm/kernel/probes.c > > index 7cd1763..179deac 100644 > > --- a/arch/arm/kernel/probes.c > > +++ b/arch/arm/kernel/probes.c > > @@ -12,11 +12,9 @@ > > */ > > > > #include <linux/kernel.h> > > -#include <linux/kprobes.h> > > #include <asm/system_info.h> > > How well has this code been tested?
>From the error below I assume only when __LINUX_ARM_ARCH__ >= 7 I have v5 and v6 hardware and will give it a go on those. I would do v4 but I've no idea how to get a kernel onto the Assabet I rescued from a skip... > This file doesn't even build because > (I suspect) the above change: > > arch/arm/kernel/probes.c: In function 'test_alu_write_pc_interworking': > arch/arm/kernel/probes.c:68:2: error: implicit declaration of function > 'BUG_ON' [-Werror=implicit-function-declaration] > make[2]: *** [arch/arm/kernel/probes.o] Error 1 > > This is because linux/kprobes.h includes linux/bug.h, which would provide > the requirements for BUG_ON(). -- Tixy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
