Am 03.03.2014 09:44, schrieb Vineet Gupta: > On Monday 03 March 2014 05:26 AM, Richard Weinberger wrote: >> Use the more generic functions get_signal() signal_setup_done() >> for signal delivery. >> >> Signed-off-by: Richard Weinberger <[email protected]> > > I gave the git branch some light testing and it works well.
Thx! > Minor comment below, otherwise > > Acked-by: Vineet Gupta <[email protected]> > > P.S. Since this depends on translate_sig change, I can't possibly take it via > ARC > tree. I hope we can merge this via Al's signal.git tree. > Thx, > -Vineet > >> --- >> arch/arc/kernel/signal.c | 39 +++++++++++++++------------------------ >> 1 file changed, 15 insertions(+), 24 deletions(-) >> >> diff --git a/arch/arc/kernel/signal.c b/arch/arc/kernel/signal.c >> index 7e95e1a..c2031e2 100644 >> --- a/arch/arc/kernel/signal.c >> +++ b/arch/arc/kernel/signal.c >> @@ -179,14 +179,13 @@ static inline int map_sig(int sig) >> } >> >> static int >> -setup_rt_frame(int signo, struct k_sigaction *ka, siginfo_t *info, >> - sigset_t *set, struct pt_regs *regs) >> +setup_rt_frame(struct ksignal *ksig, sigset_t *set, struct pt_regs *regs) >> { >> struct rt_sigframe __user *sf; >> unsigned int magic = 0; >> int err = 0; >> >> - sf = get_sigframe(ka, regs, sizeof(struct rt_sigframe)); >> + sf = get_sigframe(&ksig->ka, regs, sizeof(struct rt_sigframe)); > > Can we pass ksig pointer kere (and a pairing change to get_sigframe). This > will > reduce the code churn when we do the sigsp() change in there. Will do! Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
