On Wed, 5 Mar 2014, Andrew Morton wrote:
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -315,6 +315,9 @@ struct mem_cgroup {
> > /* OOM-Killer disable */
> > int oom_kill_disable;
> >
> > + /* reserves for handling oom conditions, protected by res.lock */
> > + unsigned long long oom_reserve;
>
> Units? bytes, I assume.
>
Yes, fixed.
> > /* set when res.limit == memsw.limit */
> > bool memsw_is_minimum;
> >
> > @@ -5936,6 +5939,51 @@ static int mem_cgroup_oom_control_write(struct
> > cgroup_subsys_state *css,
> > return 0;
> > }
> >
> > +static int mem_cgroup_resize_oom_reserve(struct mem_cgroup *memcg,
> > + unsigned long long new_limit)
> > +{
> > + struct res_counter *res = &memcg->res;
> > + u64 limit, usage;
> > + int ret = 0;
>
> The code mixes u64's and unsigned long longs in inexplicable ways.
> Suggest using u64 throughout.
>
Ok!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
