On Tue, Feb 18, 2014 at 02:55:38PM +0000, Lee Jones wrote:
> Take some known parameters, namely size and number of sectors and use
> them to determine weather a device can support 32bit addressing or not.
> If it can, set the associated flash capability flag for latter use.
>
> Acked-by Angus Clark <[email protected]>
> Signed-off-by: Lee Jones <[email protected]>
> ---
> drivers/mtd/devices/st_spi_fsm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/devices/st_spi_fsm.c
> b/drivers/mtd/devices/st_spi_fsm.c
> index 68fa12e..1d7a13a0 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -670,6 +670,10 @@ static int stfsm_probe(struct platform_device *pdev)
> return -ENODEV;
> fsm->info = info;
>
> + /* Use device size to determine address width */
> + if (info->sector_size * info->n_sectors > 0xFFFFFF)
Shouldn't you compare:
if (info->sector_size * info->n_sectors > 0x1000000)
?
A device of size 0x1000000 can be addressed completely with only the
lower 24 bits.
> + info->flags |= FLASH_FLAG_32BIT_ADDR;
> +
> platform_set_drvdata(pdev, fsm);
>
> fsm->mtd.dev.parent = &pdev->dev;
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
