On 2014/3/25 11:00, Zheng Li wrote:
> In bond mode tlb and alb, inactive slaves should keep inactive flag to
> 1 to refuse to receive broadcast packets. Now, active slave send broadcast
> packets
> (for example ARP requests) which will arrive inactive slaves on same host
> from switch,
> but inactive slave's inactive flag is zero that cause bridge receive the
> broadcast
> packets to produce a wrong entry in forward table. Typical situation is domu
> send some
> ARP request which go out from dom0 bond's active slave, then the ARP
> broadcast request
> packets go back to inactive slave from switch, because the inactive slave's
> inactive
> flag is zero, kernel will receive the packets and pass them to bridge, that
> cause dom0's
> bridge map domu's MAC address to port of bond, bridge should map domu's MAC
> to port of vif.
>
> Signed-off-by: Zheng Li <zheng.x...@oracle.com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index e5628fc..8761df6 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3062,7 +3062,7 @@ static int bond_open(struct net_device *bond_dev)
> && (slave != bond->curr_active_slave)) {
> bond_set_slave_inactive_flags(slave,
>
> BOND_SLAVE_NOTIFY_NOW);
> - } else {
> + } else if (!bond_is_lb(bond)) {
> bond_set_slave_active_flags(slave,
>
> BOND_SLAVE_NOTIFY_NOW);
> }
>
I think you did not fix the problem completely, the state monitor will change
the status for the slaves
and the inactive slave still could receive the broadcast.
Regards
Ding
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
