On Mon, 31 Mar 2014 15:21:17 -0700 Conrad Meyer <cse....@gmail.com> wrote:
> >> + if (get_unaligned_le16(&b->sector_size) != 0 || b->sec_per_clus != 0
> >> ||
> >> + b->reserved != 0 || b->fats != 0 ||
> >> + get_unaligned_le16(&b->dir_entries) != 0 ||
> >> + get_unaligned_le16(&b->sectors) != 0 || b->media != 0 ||
> >> + b->fat_length != 0 || b->secs_track != 0 || b->heads != 0 ||
> >> + b->secs_track != 0 || b->heads != 0)
> >
> > Impressive!
>
> I aim to please.
No great improvements immediately occur to me ;)
One could do
/* nice comment */
if (get_unaligned_le16(&b->sector_size) != 0)
return;
/* another nice comment */
if (b->sec_per_clus != 0)
return;
...
but one would quickly run out of nice comments.
You could do s/ != 0//g.
> Not sure what would be better -- memcmp() part of the
> struct to a zeroed array?
memcmp would be hacky. And possibly buggy if there are holes in the
struct, which is arch-dependent, shudder.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
