Struan Bartlett <struan.bartl...@gmail.com> :
[...]
> --- a/drivers/net/netconsole.c        2014-03-31 04:40:15.000000000 +0100
> +++ b/drivers/net/netconsole.c        2014-04-01 11:58:50.000000000 +0100
> @@ -15,6 +15,7 @@
>   *               generic card hooks
>   *               works non-modular
>   * 2003-09-07    rewritten with netpoll api
> + * 2014-03-31    tty driver by Struan Bartlett

Useless.

[...]
> +static int netconsole_tty_put_char(struct tty_struct *tty, unsigned char ch)
> +{
> +     char temp[2] = { ch, 0 };
> +     _write_msg(temp, 1);

Please add an empty line after declaration.

[...]
> @@ -802,11 +857,39 @@ static int __init init_netconsole(void)
>       if (err)
>               goto undonotifier;
>  
> +     netconsole_tty_driver = alloc_tty_driver(1);

alloc_tty_driver is said deprecated in include/linux/tty_driver.h

http://marc.info/?l=linux-netdev&m=139629339513575 may delay things a bit.
If so please be patient.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to