On 04/24, Srikar Dronamraju wrote:
>
> Acked-by: Srikar Dronamraju <[email protected]>

Thanks, included!

> > +           tu->filter.nr_systemwide--;
> >             done = tu->filter.nr_systemwide;
> > -           tu->filter.nr_systemwide++;
> >     }
>
> Nit: I think 2 lines can be made into
>  done = --tu->filter.nr_systemwide;
...
> > -           tu->filter.nr_systemwide--;
> >             done = tu->filter.nr_systemwide;
> > +           tu->filter.nr_systemwide++;
> >     }
>
> Nit: Similarly lines can be made into
>  done = tu->filter.nr_systemwide++;

Yes, perhaps, but this has nothing to do with this patch, it does not
change this code.

And can't resist... you know, initially I wrote this code this way, but
then I decided to make it more straightforward to avoid the potential nits
from reviewers ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to