On Sat, May 03, 2014 at 11:00:35PM +0300, Tair Rzayev wrote: > > On 2014.04.26. 01:24, Greg KH wrote: > > On Mon, Apr 21, 2014 at 08:42:47PM +0300, Tair wrote: > >> From: Tair Rzayev <[email protected]> > >> > >> Fix "Should be static" sparse warning: > >> * Add Check_D_MediaFmt() declaration to smil.h; > >> * Move Check_D_MediaFmt() implementation up in smilmain.c to keep > >> all the non-static functions at the top of the file; > >> * Include "init.h" into "smil.h", remove externs from "smil.h" > >> which are no longer needed; > >> * SM_Init[] and SM_Rdwr[] are renamed because otherwise SM_Init[] > >> collides with SM_Init() from "smil.h". > > > > That's a lot of things to do all at once. > > > > In fact, it doesn't apply to my tree anymore because someone else just > > did a part of what you did, so this might not be needed anymore. Can > > you please rebase your patch on top of my staging-next branch on the > > staging.git tree on git.kernel.org and resend it? > > > > thanks, > > > > greg k-h > > > > Rebased against suggested tree and branch. > > Most of the changes were already applied by another developer so leaving only > cosmetic stuff from my original patch: > * Move Check_D_MediaFmt() implementation up in smilmain.c to keep all the > non-static functions at the top of the file; > * Remove unnecessary extern and newlines from "init.h"; > > Signed-off-by: Tair Rzayev <[email protected]> > --- > drivers/staging/keucr/init.h | 4 ---- > drivers/staging/keucr/smilmain.c | 34 +++++++++++++++++----------------- > 2 files changed, 17 insertions(+), 21 deletions(-)
Please resend this as a whole new email, one that I don't have to edit by hand in order to apply it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
