Vladimir Murzin <murzin.v <at> gmail.com> writes: > > Andrey Ryabinin <a.ryabinin <at> samsung.com> writes: > > > > > memset doesn't work right for following example: > > > > signed char c = 0xF0; > > memset(addr, c, size); > > > > Variable c is signed, so after typcasting to int the value will be 0xFFFFFFF0. > > This value will be passed through r1 regitster to memset function. > > memset doesn't zero out upper bytes in r1, so memory will be filled > > with 0xFFFFFFF0 instead of expected 0xF0F0F0F0. > > It behaves the same as a generic implementation in lib/string.c, moreover > gcc built-in behaves the same. So it looks like expected behavior and POSIX > Programmer's Manual (man 3posix memset) explicitly says that "c" is > converted to unsigned char. > > Cheers > Vladimir > >
Sorry, had a bad coffee when posted it ;) It behaves /different/, but it is here for many years... doesn't this change break something? iow, it possible that some user rely on this behavior... Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

