On 12 May 11:26 PM, Ezequiel Garcia wrote:
> On 12 May 05:50 PM, Brian Norris wrote:
> > > There are some guidelines about attributes in
> > > 'Documentation/filesystems/sysfs.txt'
> > > Though it's acceptable to put array of values of the "same type" in
> > > single sysfs file,
> > > But I'm still not confident on having all members of 'struct ecc_stats'
> > > being
> > > represented by single sysfs file
> > [...]
> >
> > I agree, it looks like the sysfs policy would recommend against putting
> > distinct properties in the same file.
> >
[..]
> > So I personally might lean toward "one file per attribute" here.
> >
Brian,
Having agreed on doing one file per attribute, I'm now not sure how to
name them. Maybe you can give me a hand?
Let me add some context: these are the per-MTD partition fields of the
mtd_ecc_stats struct, although two of them aren't related to ECC, but to
the bad blocks management. This is the struct:
struct mtd_ecc_stats {
__u32 corrected;
__u32 failed;
__u32 badblocks;
__u32 bbtblocks;
};
How about the following?
* corrected_bits
* uncorrectable_errors
* badblocks
* bbtblocks
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
