On Wed, May 14, 2014 at 03:55:32PM +0100, Daniel Thompson wrote: > The behaviour of the UART poll_put_char infrastructure is inconsistent > with respect to linefeed conversions. This in turn leads to difficulty > using kdb on serial ports that are not also consoles > (e.g. console=ttyAMA0,115200 kgdboc=ttyAMA1,115200). > > The following drivers automatically convert '\n' to '\r\n' inside their > own poll functions but the remaining seventeen do not: > > serial8250, cpm, pch_uart, serial_pxa, serial_txx9, > > This can be made fully consistent but performing the conversion in > uart_poll_put_char(). A similar conversion is already made inside > uart_console_write() but it is optional for drivers to use this > function. Fortunately we can be confident the translation is safe > because the (very common) 8250 already does this translation. > > Signed-off-by: Daniel Thompson <daniel.thomp...@linaro.org> > Cc: Kumar Gala <ga...@kernel.crashing.org> > Cc: Pantelis Antoniou <pa...@intracom.gr> > Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Cc: Joe Schultz <jschu...@xes-inc.com> > Cc: Loic Poulain <loic.poul...@intel.com> > Cc: Kyle McMartin <k...@infradead.org> > Cc: Stephen Warren <swar...@nvidia.com> > Cc: Ingo Molnar <mi...@elte.hu> > Cc: Paul Gortmaker <paul.gortma...@windriver.com> > Cc: Grant Likely <grant.lik...@linaro.org> > Cc: Rob Herring <rob.herr...@calxeda.com> > Cc: Jingoo Han <jg1....@samsung.com> > Cc: Christophe Leroy <christophe.le...@c-s.fr> > --- > drivers/tty/serial/8250/8250_core.c | 5 -----
This patch doesn't apply to my tty-next branch anymore, as it seems that part of it is already there, right? Can you respin this whole series and resend? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
