Hi Jiri,

2014-06-19 (목), 13:41 +0200, Jiri Olsa:
> Adding report.show-headers config file option to setup
> the appearance of the columns headers.
> 
> Currently columns headers are displayed by default, following
> lines in ~/.perfconfig file will disable that:
> 
>   [report]
>         show-headers = true

This also applies to perf top, right?  And it's TUI-specific.  So how
about calling it something like "tui.show-headers"?


[SNIP]
> @@ -35,6 +35,7 @@ struct symbol_conf symbol_conf = {
>       .demangle               = true,
>       .cumulate_callchain     = true,
>       .symfs                  = "",
> +     .show_headers           = -1,

Hmm.. why not just making it boolean and set it to true (like others)?

Thanks,
Namhyung


>  };
>  
>  static enum dso_binary_type binary_type_symtab[] = {
> diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
> index 615c752..8f1854a 100644
> --- a/tools/perf/util/symbol.h
> +++ b/tools/perf/util/symbol.h
> @@ -139,6 +139,7 @@ struct symbol_conf {
>                       *sym_from_list,
>                       *sym_to_list;
>       const char      *symfs;
> +     int             show_headers;
>  };
>  
>  extern struct symbol_conf symbol_conf;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to