On Mon, 2014-06-23 at 12:08 -0400, Steven Rostedt wrote: > On Sun, 22 Jun 2014 09:38:05 +0200 > Johannes Berg <[email protected]> wrote: > > > > Looking at the code though, I'm not sure it's a pure optimisation - if > > you do say putc() after a failed puts(), without this code the putc() > > would succeed? I can't tell right now if that's really a problem, but it > > seems you could get some odd behaviour out of it. > > How would putc() still succeed? We're just talking about the "full" > field. It would still do the length check: > > if (s->len >= (PAGE_SIZE - 1)) > return 0;
Right, but the puts() could fail if not all of the string fits, and a subsequent putc() might fit. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
