Paul Gortmaker <[email protected]> writes: > On 14-06-25 04:46 AM, Rasmus Villemoes wrote: >> The function number_prefix() can currently only return 1 if its >> argument is the empty string: If line 3 is reached and *sym (now the >> second character in the argument) is not '.', 0 is returned. However, >> if that character is '.', the first assignment to c is that same '.', >> which obviously fails to be a digit. > > I'd suggest you expand the commit log to actually list the end-user > visible symptom and the use case that this actually fixes, since it > isn't obvious to me at all.
Sorry, it isn't obvious to me either. I just stumbled on it reading the code; the rest of modpost.c is too deep magic for me. Maybe there are no user-visible symptoms, and maybe that means it is not worth fixing, in which case I'll just add scripts/mod/modpost.c to my mental .ocpdignore. Thanks, Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
