On Thu, Jul 3, 2014 at 6:14 AM, Stanimir Varbanov <[email protected]> wrote: [...] > +static const struct of_device_id qpnp_rtc_table[] = { > + { .compatible = "qcom,qpnp-rtc", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, rtc_qpnp_table);
We have had a lot of discussions related to how to name pm8x41 drivers; as they obviously fall under pm8xxx in most peoples eyes. As you guys have explained, QPNP is defining the split of address space and how interrupts are layed out. To me this does however not say anything related to the actual functionality; e.g. the rtc in this case. Are you by this patch saying that this is the one and only rtc hardware that will ever be spun under the QPNP umbrella? I would expect the naming to be more specific; and definitely the compatible to be specific. This concern goes for all the qpnp drivers. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
