On Sun, 13 Jul 2014 09:05:46 +0800 Baoquan He <[email protected]> wrote:
> On some ARCHs modules range is eauql to vmalloc range. E.g on i686
> "#define MODULES_VADDR VMALLOC_START"
> "#define MODULES_END VMALLOC_END"
> This will cause 2 duplicate program segments in /proc/kcore, makes
> user confused. In this patch a judgment added to check if modules
> range is equal to vmalloc range. If yes, just skip adding the modules
> range.
>
> ...
>
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -610,8 +610,10 @@ static void __init proc_kcore_text_init(void)
> struct kcore_list kcore_modules;
> static void __init add_modules_range(void)
> {
> - kclist_add(&kcore_modules, (void *)MODULES_VADDR,
> - MODULES_END - MODULES_VADDR, KCORE_VMALLOC);
> + if (MODULES_VADDR != VMALLOC_START) {
> + kclist_add(&kcore_modules, (void *)MODULES_VADDR,
> + MODULES_END - MODULES_VADDR, KCORE_VMALLOC);
> + }
> }
> #else
> static void __init add_modules_range(void)
But if some application or script is using the modules range, won't
this patch cause breakage on some architectures?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
