On Wed, Jul 23, 2014 at 08:07:18PM +0200, Borislav Petkov wrote:
> Date: Wed, 23 Jul 2014 20:07:18 +0200
> From: Borislav Petkov <b...@alien8.de>
> To: "Chen, Gong" <gong.c...@linux.intel.com>
> Cc: linux-kernel@vger.kernel.org, mi...@kernel.org, t...@linutronix.de,
> pau...@samba.org, b...@kernel.crashing.org, tony.l...@intel.com,
> h...@zytor.com, jkos...@suse.cz, rafael.j.wyso...@intel.com,
> li...@arm.linux.org.uk, r...@linux-mips.org, schwidef...@de.ibm.com,
> da...@davemloft.net, v...@zeniv.linux.org.uk, fweis...@gmail.com,
> c...@linux.com, a...@linux-foundation.org, ax...@kernel.dk,
> jbottom...@parallels.com, ne...@suse.de, christoffer.d...@linaro.org,
> rost...@goodmis.org, r...@kernel.org, gre...@linuxfoundation.org,
> mho...@suse.cz, da...@fromorbit.com
> Subject: Re: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup
> User-Agent: Mutt/1.5.23 (2014-03-12)
>
> On Tue, Jul 22, 2014 at 09:58:48PM -0400, Chen, Gong wrote:
> > Remove XXX_FROZEN state from x86/pci/amd_bus.
> >
> > Signed-off-by: Chen, Gong <gong.c...@linux.intel.com>
> > ---
> > arch/x86/pci/amd_bus.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
> > index c20d2cc..30f0fca9 100644
> > --- a/arch/x86/pci/amd_bus.c
> > +++ b/arch/x86/pci/amd_bus.c
> > @@ -341,9 +341,8 @@ static int amd_cpu_notify(struct notifier_block *self,
> > unsigned long action,
> > void *hcpu)
> > {
> > int cpu = (long)hcpu;
> > - switch (action) {
> > + switch (action & ~CPU_TASKS_FROZEN) {
> > case CPU_ONLINE:
> > - case CPU_ONLINE_FROZEN:
> > smp_call_function_single(cpu, enable_pci_io_ecs, NULL, 0);
> > break;
> > default:
>
> Or you can kill all the switch-case gunk and make it even more readable:
>
But what if new action is added? We have to change it back. If you prefer
to use that style I can update in next version.
signature.asc
Description: Digital signature
