Hi,
> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
> Sent: Tuesday, July 29, 2014 8:43 PM
> To: Chao Yu
> Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org;
> linux-f2fs-de...@lists.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH 06/11] f2fs: skip unnecessary data writes
> during fsync
>
> On Tue, Jul 29, 2014 at 07:39:45PM +0800, Chao Yu wrote:
> > Hi,
> >
> > > -----Original Message-----
> > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
> > > Sent: Saturday, July 26, 2014 6:47 AM
> > > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org;
> > > linux-f2fs-de...@lists.sourceforge.net
> > > Cc: Jaegeuk Kim
> > > Subject: [f2fs-dev] [PATCH 06/11] f2fs: skip unnecessary data writes
> > > during fsync
> > >
> > > This patch intends to improve the fsync performance by skipping remaining
> > > the
> > > recovery information, only when there is no data that we should recover.
> > >
> > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
Reviewed-by: Chao Yu <chao2...@samsung.com>
> > > ---
> > > fs/f2fs/file.c | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > > index 7c652b3..121689a 100644
> > > --- a/fs/f2fs/file.c
> > > +++ b/fs/f2fs/file.c
> > > @@ -133,6 +133,17 @@ int f2fs_sync_file(struct file *file, loff_t start,
> > > loff_t end, int
> > > datasync)
> > > return ret;
> > > }
> > >
> > > + /*
> > > + * if there is no written data, don't waste time to write recovery info.
> > > + */
> > > + if (!is_inode_flag_set(fi, FI_APPEND_WRITE) &&
> > > + !exist_written_data(sbi, inode->i_ino, APPEND_INO)) {
> > > + if (is_inode_flag_set(fi, FI_UPDATE_WRITE) &&
> > > + exist_written_data(sbi, inode->i_ino, UPDATE_INO))
> >
> > Should we shift this to is_inode_flag_set(fi, FI_UPDATE_WRITE) ||
> > exist_written_data(sbi, inode->i_ino, UPDATE_INO) ?
>
> Hehe, I found that and was going to submit new patch. :)
> Small changes are not a big deal, so I'll test and then push them into the
> tree.
> The for-next tree can be rebased all the time, so if you have any suggestion,
> let me know.
It's OK, I will. :)
Thanks
>
> Thanks,
>
> >
> > > + goto flush_out;
> > > + goto out;
> > > + }
> > > +
> > > /* guarantee free sections for fsync */
> > > f2fs_balance_fs(sbi);
> > >
> > > @@ -188,6 +199,11 @@ int f2fs_sync_file(struct file *file, loff_t start,
> > > loff_t end, int
> > > datasync)
> > > ret = wait_on_node_pages_writeback(sbi, inode->i_ino);
> > > if (ret)
> > > goto out;
> > > +
> > > + /* once recovery info is written, don't need to tack this */
> > > + remove_dirty_inode(sbi, inode->i_ino, APPEND_INO);
> > > +flush_out:
> > > + remove_dirty_inode(sbi, inode->i_ino, UPDATE_INO);
> > > ret = f2fs_issue_flush(F2FS_SB(inode->i_sb));
> > > }
> > > out:
> > > --
> > > 1.8.5.2 (Apple Git-48)
> > >
> > >
> > > ------------------------------------------------------------------------------
> > > Want fast and easy access to all the code in your enterprise? Index and
> > > search up to 200,000 lines of code with a free copy of Black Duck
> > > Code Sight - the same software that powers the world's largest code
> > > search on Ohloh, the Black Duck Open Hub! Try it now.
> > > http://p.sf.net/sfu/bds
> > > _______________________________________________
> > > Linux-f2fs-devel mailing list
> > > linux-f2fs-de...@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
