(I guess I need to refresh my regular expression skills ...) Thanks, this will be just great! Dotan
> -----Original Message----- > From: Joe Perches [mailto:[email protected]] > Sent: Monday, August 04, 2014 6:27 PM > To: Dotan Barak > Cc: [email protected] > Subject: Re: checkpatch.pl report about "Missing blank line after > declarations" in a structure definition > > On Mon, 2014-08-04 at 15:19 +0000, Dotan Barak wrote: > > In our code (I take it as an example), we used > > MLX5_DECLARE_DOORBELL_LOCK, So I guess that the regular expression > > that you mentioned will fail on it (because the "_" is not allowed to be > repeated). > > > > So, I would change it a little bit to allow people to use underscore as a > > word > separator. > [] > > > Maybe: > > > > > > (?:$Storage\s+)(?:[A-Z_][A-Z0-9]+_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0- > > > 9]+){1,2} > > What I suggested should allow any of: > > DECLARE_FOO > _FOO_DEFINE_BAR > FOO_BAR_DEFINE_BAZ > FOO_BAR_DECLARE_BAZ_QUX > > where FOO/BAR/BAZ/QUX can also have digits -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
