On Sat, 9 Aug 2014, Aneesh Kumar K.V wrote: > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > > --- a/mm/hugetlb_cgroup.c > > +++ b/mm/hugetlb_cgroup.c > > @@ -275,6 +275,7 @@ static ssize_t hugetlb_cgroup_write(struct > > kernfs_open_file *of, > > ret = res_counter_memparse_write_strategy(buf, &val); > > if (ret) > > break; > > + val = ALIGN(val, 1ULL << huge_page_shift(&hstates[idx])); > > Do we really need ULL ? max value should fit in unsigned long right ? >
I usually just go for type agreement. > > ret = res_counter_set_limit(&h_cg->hugepage[idx], val); > > break; > > default: > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/