> -----Original Message----- > From: [email protected] > [mailto:[email protected]] > On Behalf Of Rickard Strandqvist > Sent: Sunday, August 17, 2014 5:40 PM > To: Steve Wise; Roland Dreier > Cc: Rickard Strandqvist; Sean Hefty; Hal Rosenstock; > [email protected]; linux- > [email protected] > Subject: [PATCH] infiniband: hw: cxgb3: cxio_hal.c: Cleaning up missing > null-terminate after > strncpy call > > Added a guaranteed null-terminate after call to strncpy. > > Signed-off-by: Rickard Strandqvist <[email protected]> > --- > drivers/infiniband/hw/cxgb3/cxio_hal.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c > b/drivers/infiniband/hw/cxgb3/cxio_hal.c > index de1c61b4..5fc04e4 100644 > --- a/drivers/infiniband/hw/cxgb3/cxio_hal.c > +++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c > @@ -933,6 +933,7 @@ int cxio_rdev_open(struct cxio_rdev *rdev_p) > netdev_p = rdev_p->t3cdev_p->lldev; > strncpy(rdev_p->dev_name, rdev_p->t3cdev_p->name, > T3_MAX_DEV_NAME_LEN); > + rdev_p->dev_name[T3_MAX_DEV_NAME_LEN - 1] = '\0'; > } else { > PDBG("%s t3cdev_p or dev_name must be set\n", __func__); > return -EINVAL;
cxio_rdev_open() is called only by open_rnic_dev() which allocates the device structure by calling ib_alloc_device() which uses kzalloc(). So this change really isn't needed, is it? Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
