On 19/08/14 12:58, Peter Hurley wrote:
> On 08/19/2014 05:08 AM, Daniel Thompson wrote:
>> On 18/08/14 19:30, Peter Hurley wrote:
>
> [cut]
>
>>>> +static int pl011_poll_init(struct uart_port *port)
>>>> +{
>>>> + struct uart_amba_port *uap = (struct uart_amba_port *)port;
>>>
>>> Please use container_of() in new code.
>>
>> Ok.
>>
>> Personally I dislike a file that mixes casts and conatiner_of but I
>> guess I can make both of us happy by switching the whole driver to
>> container_of. Separate patch again?
>
> The change below makes the uap local unnecessary, so you can skip the
> container_of() change, if you'd prefer.
I realized that myself although not until after I'd replaced all the
casts with container_of()...
So I'll keep the patch for now but can drop it if anyone takes against it.
Thanks
Daniel.
>
>>>> + int retval;
>>>> +
>>>> + retval = pl011_hwinit(port);
>>>> +
>>>> +#ifdef CONFIG_KGDB_FIQ
>>>> + if (retval == 0)
>>>> + kgdb_register_fiq(uap->port.irq);
>>>
>>> The uap->port dereference is unnecessary since the port parameter
>>> is the same thing.
>>>
>>> kgdb_register_fiq(port->irq);
>>
>> Ok.
>
> Thanks,
> Peter Hurley
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
