On 08/08/14 13:07, Julia Lawall wrote: > From: Julia Lawall <[email protected]> > > Of_node_put supports NULL as its argument, so the initial test is not > necessary. Furthermore, native_mode cannot be NULL at this point. > > Suggested by Uwe Kleine-König. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > > -if (e) > of_node_put(e); > // </smpl> > > Signed-off-by: Julia Lawall <[email protected]> > > --- > drivers/video/of_display_timing.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/of_display_timing.c > b/drivers/video/of_display_timing.c > index 987edf1..339f831 100644 > --- a/drivers/video/of_display_timing.c > +++ b/drivers/video/of_display_timing.c > @@ -233,8 +233,7 @@ struct display_timings *of_get_display_timings(struct > device_node *np) > return disp; > > timingfail: > - if (native_mode) > - of_node_put(native_mode); > + of_node_put(native_mode); > display_timings_release(disp); > entryfail: > kfree(disp); >
Thanks, queued for 3.18. Tomi
signature.asc
Description: OpenPGP digital signature
