Hi Xiubo
Thank you for your patch.
This clean-up is very nice for me.
But, I have 1 small comment
> asoc_simple_card_sub_parse_of(struct device_node *np,
> struct asoc_simple_dai *dai,
> struct device_node **p_node,
> - const char **name)
> + const char **name,
> + unsigned int *daifmt)
> {
> struct device_node *node;
> struct clk *clk;
> u32 val;
> int ret;
>
> + if (!daifmt)
> + return -EINVAL;
> +
> + /*
> + * Parse format, bitclock-inversion and frame-inversion
> + * for DAI each device.
> + */
> + *daifmt = snd_soc_of_parse_daifmt(np, NULL, NULL, NULL);
> + *daifmt &= ~(SND_SOC_DAIFMT_MASTER_MASK | SND_SOC_DAIFMT_FORMAT_MASK);
(snip)
> ret = asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai,
> &dai_link->cpu_of_node,
> - &dai_link->cpu_dai_name);
> + &dai_link->cpu_dai_name,
> + &daifmt);
(snip)
> + dai_props->cpu_dai.fmt |= daifmt;
(snip)
> ret = asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai,
> &dai_link->codec_of_node,
> - &dai_link->codec_dai_name);
> + &dai_link->codec_dai_name,
> + &daifmt);
(snip)
> + dai_props->codec_dai.fmt |= daifmt;
These are using
asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai, xxx)
asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai, xxx)
I guess, asoc_simple_card_sub_parse_of() can update
below inside function
dai_props->cpu_dai.fmt |= daifmt;
dai_props->codec_dai.fmt |= daifmt;
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
