>> > Same comments as the previous ones, please redo all of these patches. >> > >> Should all the alterations be in one big single patch, insted of small ones? > > Your first version broke the build if we applied only the first patch. > That's not allowed. I now understand that, thank you.
> Also the new rtw_sys_remove_one() function isn't called. I was confused > by it as well. It doesn't "remove one", it removes everything. The function it's not new, I just converted it from the proc to defugfs, It can be renamed. > Do we need to support llseek? Probably not... I'll check it. > How have you tested this? Have you tested module unloading? Yes, I've tested it several times and unloaded without issues. Thank you for your comments, Best Regards, Miguel Oliveira -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
