Hi Erik, On Tue, 2 Sep 2014 12:52:12 +0200 Erik van Luijk <[email protected]> wrote:
> Signed-off-by: Erik van Luijk <[email protected]> Except for the nitpicks you'll find below, you have my Acked-by: Boris Brezillon <[email protected]> > --- > arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++ > arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi > b/arch/arm/boot/dts/at91sam9g45.dtsi > index 932a669..bf62c18 100644 > --- a/arch/arm/boot/dts/at91sam9g45.dtsi > +++ b/arch/arm/boot/dts/at91sam9g45.dtsi > @@ -1070,6 +1070,13 @@ > status = "disabled"; > }; > > + rtc@fffffdb0 { > + compatible = "atmel,at91rm9200-rtc"; > + reg = <0xfffffdb0 0x30>; The RTC registers goes from 0xfffffdb0 to 0xfffffdc0, which means the size is 0x10 and not 0x30. This is not important here, because the following region is marked as reserved, but we prefer to keep the DT consistent with the datasheet. > + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + status = "disabled"; > + }; > + > spi0: spi@fffa4000 { > #address-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts > b/arch/arm/boot/dts/at91sam9m10g45ek.dts > index 96ccc7d..2dd2347 100644 > --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts > +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts > @@ -70,6 +70,9 @@ > > watchdog@fffffd40 { > status = "okay"; > + > + rtc@fffffdb0 { > + status = "okay"; Try to keep SoC and board changes in distinct commits. > }; > > mmc0: mmc@fff80000 { Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
