In current implementation we have floating ascii column in the tail of the
dump.
For example, for row size equal to 16 the ascii column as in following table
group size \ length 8 12 16
1 50 50 50
2 22 32 42
4 20 29 38
8 19 - 36
This patch makes it the same independently of amount of bytes dumped.
The change is safe since all current users, which use ASCII part of the dump,
rely on the group size equal to 1. The patch doesn't change behaviour for such
group size (see the table above).
Signed-off-by: Andy Shevchenko <[email protected]>
---
lib/hexdump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/hexdump.c b/lib/hexdump.c
index 8499c81..4677070 100644
--- a/lib/hexdump.c
+++ b/lib/hexdump.c
@@ -110,7 +110,7 @@ void hex_dump_to_buffer(const void *buf, size_t len, int
rowsize,
lx += scnprintf(linebuf + lx, linebuflen - lx,
"%s%16.16llx", j ? " " : "",
(unsigned long long)*(ptr8 + j));
- ascii_column = 17 * ngroups + 2;
+ ascii_column = rowsize * 2 + rowsize / 8 + 2;
break;
}
@@ -121,7 +121,7 @@ void hex_dump_to_buffer(const void *buf, size_t len, int
rowsize,
for (j = 0; j < ngroups; j++)
lx += scnprintf(linebuf + lx, linebuflen - lx,
"%s%8.8x", j ? " " : "", *(ptr4 + j));
- ascii_column = 9 * ngroups + 2;
+ ascii_column = rowsize * 2 + rowsize / 4 + 2;
break;
}
@@ -132,7 +132,7 @@ void hex_dump_to_buffer(const void *buf, size_t len, int
rowsize,
for (j = 0; j < ngroups; j++)
lx += scnprintf(linebuf + lx, linebuflen - lx,
"%s%4.4x", j ? " " : "", *(ptr2 + j));
- ascii_column = 5 * ngroups + 2;
+ ascii_column = rowsize * 2 + rowsize / 2 + 2;
break;
}
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
