On Sat, Sep 06, 2014 at 11:19:03AM -0700, Joe Perches wrote: > > Indexing a string array with an enum is generally unsafe. > > I think it better to use a switch/case like: >
The reverse side of that argument is that switch statements are slower and uglier. My understanding is that according to the c spec, "state" could be signed but in this case GCC defines it as unsigned int. So the ASSERT is ok in real life, but in theory it should check for negatives as well. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
