> >@@ -136,7 +136,6 @@ config GPIO_DWAPB > > tristate "Synopsys DesignWare APB GPIO driver" > > select GPIO_GENERIC > > select GENERIC_IRQ_CHIP > >- depends on OF_GPIO > > You cover this specific dependencies with inline ifdefs, but you lose the > CONFIG_OF depends by dropping it, and there are no such checks in the probe > routine. Assumptions of OF are not limited to probe in this driver. > > While I would like to see this assumption properly abstracted, the most > expedient/immediate fix is probably to add a depends on OF above.
Andriy, how do you think? How about depends on OF_GPIO || MFD_GPIO_DWAPB, or depends on OF_GPIO || MFD_INTEL_QUARK_I2C_GPIO? > -- > Darren > Intel Open Source Technology Center > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
