On Wed, Sep 10, 2014 at 12:34:50AM +0000, Chen, Alvin wrote: > > >@@ -136,7 +136,6 @@ config GPIO_DWAPB > > > tristate "Synopsys DesignWare APB GPIO driver" > > > select GPIO_GENERIC > > > select GENERIC_IRQ_CHIP > > >- depends on OF_GPIO > > > > You cover this specific dependencies with inline ifdefs, but you lose the > > CONFIG_OF depends by dropping it, and there are no such checks in the probe > > routine. Assumptions of OF are not limited to probe in this driver. > > > > While I would like to see this assumption properly abstracted, the most > > expedient/immediate fix is probably to add a depends on OF above. > > Andriy, how do you think? > > How about > depends on OF_GPIO || MFD_GPIO_DWAPB, or > depends on OF_GPIO || MFD_INTEL_QUARK_I2C_GPIO? >
Upon closer inspection, I think my concern is invalid. the OF header already tests for CONFIG_OF and provides no-op / -ENOSYS (tsk tsk) alternatives. So long as you can compile with "#CONFIG_OF is not set" as it is, then I withdraw my comment. Sorry for the noise. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
