On 9/21/2014 8:26 AM, Mathias Krause wrote:
- if (pr & _PAGE_PCD) - pt_dump_cont_printf(m, dmsg, "PCD "); - else - pt_dump_cont_printf(m, dmsg, " "); + pt_dump_cont(m, dmsg, "%-4s", pr & _PAGE_USER ? "USR" : "");
while you have some nice cleanups in your patch, I can't say I consider this an improvement. Yes the C standard allows ? to be used like this but no, I don't think it improves readability in general. (I think for me the main exception is NULL pointer cases, but this is not one of these) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
