On 09/22/2014 12:59 PM, Yoder Stuart-B08248 wrote:


-----Original Message-----
From: Kim Phillips [mailto:[email protected]]
Sent: Monday, September 22, 2014 11:53 AM
To: Rivera Jose-B46482
Cc: [email protected]; [email protected]; [email protected]; 
Yoder Stuart-B08248; Wood Scott-
B07421; [email protected]; [email protected]
Subject: Re: [PATCH 0/3 v2] drivers/bus: Freescale Management Complex bus 
driver patch series

On Fri, 19 Sep 2014 17:49:38 -0500
"J. German Rivera" <[email protected]> wrote:

CHANGE HISTORY

Issues pending resolution not addressed by v2:
- What to do with Doxygen comments in patch 1

It's clear they should be removed.

- Whether to move or not FSL-specific header files added in include/linux,
   by this patch series, to another location

there wasn't a valid objection against moving them under fsl/ and
changing them to use dashes instead of underscores, was there?

There was no objection, but here is the observation.  The current
convention seems to be that under include/linux are 'subsystem'
types--
    include/linux/mmc
    include/linux/spi
    include/linux/raid
     etc

There is no other "company" that has an include/linux/[company-name] that I can
see.  Freescale seems to be the only one.   And there is only a single driver
in there.  So it looks like a complete anomaly.

Why is that?

I guess we could try moving our stuff to incluce/linux/fsl and see if there is
any negative feedback on it.


Ok, unless there is any objection, we will do the following file renamings:

Patch 1/3
drivers/bus/fsl-mc/fsl_dpmng_cmd.h -> drivers/bus/fsl-mc/dpmng-cmd.h
drivers/bus/fsl-mc/fsl_dprc_cmd.h -> drivers/bus/fsl-mc/dprc-cmd.h
drivers/bus/fsl-mc/fsl_mc_sys.c -> drivers/bus/fsl-mc/mc-sys.c
include/linux/fsl_dpmng.h -> include/linux/fsl/dpmng.h
include/linux/fsl_dprc.h -> include/linux/fsl/dprc.h
include/linux/fsl_mc_cmd.h -> include/linux/fsl/mc-cmd.h
include/linux/fsl_mc_sys.h -> include/linux/fsl/mc-sys.h

Patch 2/3
drivers/bus/fsl-mc/fsl_mc_bus.c -> drivers/bus/fsl-mc/mc-bus.c
include/linux/fsl_mc.h -> include/linux/fsl/mc.h
include/linux/fsl_mc_private.h -> include/linux/fsl/mc-private.h

Patch 3/3
drivers/bus/fsl-mc/fsl_mc_dprc.c -> drivers/bus/fsl-mc/dprc-driver.c
(there is a file already named drivers/bus/fsl-mc/dprc.c)

Stuart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to