On 09/23/2014 06:11 PM, Jisheng Zhang wrote:
[ ... ]
+       dw_wdt.restart_handler.notifier_call = dw_wdt_restart_handle;
+       dw_wdt.restart_handler.priority = 128;
+       ret = register_restart_handler(&dw_wdt.restart_handler);
+       if (ret)
+               pr_warn("cannot register restart handler\n");

Please use dev_warn(&pdev->dev, ...).

Yep, that's what I thought when patching the code. But the original source is
using pr_*(), so I use pr_warn() to keep unification. Is there any better
solution?


Good point. Makes sense, then, to leave that as cleanup.

Reviewed-by: Guenter Roeck <li...@roeck-us.net>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to