On 10/14/2014 11:21 AM, Guenter Roeck wrote: > tag_protocol is now an enum, so drivers have to check against it.
Good catch, this driver got merged right in the middle of my changes from __be16 to an enum and this slipped through. > > Cc: Andrew Lunn <[email protected]> > Signed-off-by: Guenter Roeck <[email protected]> Fixes: 42f272539487e49c9ea830ad97db41eb9937d5dc ("net: DSA: Marvell mv88e6171 switch driver") Acked-by: Florian Fainelli <[email protected]> > --- > drivers/net/dsa/mv88e6171.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mv88e6171.c b/drivers/net/dsa/mv88e6171.c > index 6365e30..1020a7a 100644 > --- a/drivers/net/dsa/mv88e6171.c > +++ b/drivers/net/dsa/mv88e6171.c > @@ -206,7 +206,7 @@ static int mv88e6171_setup_port(struct dsa_switch *ds, > int p) > */ > val = 0x0433; > if (dsa_is_cpu_port(ds, p)) { > - if (ds->dst->tag_protocol == htons(ETH_P_EDSA)) > + if (ds->dst->tag_protocol == DSA_TAG_PROTO_EDSA) > val |= 0x3300; > else > val |= 0x0100; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
