On Thursday 16 October 2014 07:08 PM, Vineet Gupta wrote: > On Thursday 16 October 2014 05:05 AM, Bjorn Helgaas wrote: >> > [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() >> > definitions and could see issues from this] > Thanks for the heads up ! > > I compile tested arc tree (with kgdb) from linux-next of today, which has this > patch already and things seem to be ok. > > As a hack I reverted the patch and see that kgdb_arch_pc() becomes weak, > although > ARC version was still being pulled in final - it was recored as weak and that > cause bloat-o-meter to go awry. > > bloat-o-meter vmlinux-with-fix vmlinux-before-fix > add/remove: 0/1 grow/shrink: 1/0 up/down: 1/-8 (-7) > function old new delta > vermagic 36 37 +1 > kgdb_arch_pc 8 - -8
The ARC definition of kgdb_arch_pc is same as generic one so we might as well drop it. Can you add the patch below to your series. If not I can add it to ARC changes for this merge window. Please let me know. Thx, -Vineet ----------------------> >From f01b1db6986924e794eddc038167329d63d1fda9 Mon Sep 17 00:00:00 2001 From: Vineet Gupta <[email protected]> Date: Fri, 17 Oct 2014 13:27:03 +0530 Subject: [PATCH] ARC: kgdb: generic kgdb_arch_pc() suffices Signed-off-by: Vineet Gupta <[email protected]> --- arch/arc/kernel/kgdb.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/arc/kernel/kgdb.c b/arch/arc/kernel/kgdb.c index a2ff5c5d1450..ecf6a7869375 100644 --- a/arch/arc/kernel/kgdb.c +++ b/arch/arc/kernel/kgdb.c @@ -158,11 +158,6 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, return -1; } -unsigned long kgdb_arch_pc(int exception, struct pt_regs *regs) -{ - return instruction_pointer(regs); -} - int kgdb_arch_init(void) { single_step_data.armed = 0; -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
