On Wed, Oct 15, 2014 at 04:47:27PM -0400, David Miller wrote: > From: "Michael S. Tsirkin" <[email protected]> > Date: Wed, 15 Oct 2014 16:23:28 +0300 > > > You used __netif_subqueue_stopped but that seems to use > > a slightly more expensive test_bit internally. > > More expensive in what sense? It should be roughly the same > as "x & y" sans the volatile.
I really just meant volatile - this might prevent some compiler optimizations. I have't actually checked the produced binary so I don't know for sure. > Anyways I'm ambivalent and I want to see this bug fixes, so I'll > apply your patch. > > Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
