On Wed, Oct 08, 2014 at 11:53:33AM +0800, Lai Jiangshan wrote: > There are two aims for get_online_cpus(): > 1) Protects cpumask_of_node(node). (CPUs should stay stable) > 2) Protects the pwq-allocation and installation > > But both aims are settled by other methods in previous patches: > cpumask_of_node(node) is replaced by wq_unbound_online_cpumask, and > the pwq-allocation and installation are changed to be protected by > wq_pool_mutex. Now the get_online_cpus() is no reason to exist, > remove it! > > Signed-off-by: Lai Jiangshan <[email protected]>
Well, this is very marginal and we want to add comments explaining why this is safe, but yeah I guess it's an improvement. Can you please add comments explaining what states are depended upon and that they are all protected by pool mutex? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
