Hi Andrew, On 11/06/2014 05:00 AM, Andrew Morton wrote: > On Wed, 5 Nov 2014 09:56:20 -0500 Benjamin LaHaise <[email protected]> wrote: > >> On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: >>> ping... >> >> I need someone a bit more familiar with this area of code to chime in on >> reviewing this. Andrew, can you provide any feedback on this fix? > > That looks like a sensible solution and the changelog is good. A > couple of suggested modifications: > > - Don't use the term "pinned" in the changelog without explaining it > - it's a terribly ambiguous term. I assume here you mean "pinned by > elevating the page's refcount"?
Yes. > > - Could we have just one wee little code comment, explaining why > aio_fs_backing_dev_info exists, what function it is serving? Put > yourself in the position of a reader wondering "why is this here". > . Got it. Thanks for your suggestion. Will update it soon. Regards, Gu > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
