On Thu, 13 Nov 2014, Russell King - ARM Linux wrote: > On Thu, Nov 13, 2014 at 12:44:22PM -0500, Nicolas Pitre wrote: > > On Thu, 13 Nov 2014, Pankaj Dubey wrote: > > > > > If BL_SWITCHER is enabled but SUSPEND and CPU_IDLE is not enabled > > > we are getting following config warning. > > > > > > warning: (BL_SWITCHER) selects CPU_PM which has unmet direct > > > dependencies (SUSPEND || CPU_IDLE) > > > > > > So BL_SWITCHER should enable CPU_PM only if either of SUSPEND or > > > CPU_IDLE is selected. > > > > > > Signed-off-by: Pankaj Dubey <[email protected]> > > > --- > > > arch/arm/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > index 9d580d0..fe3d969 100644 > > > --- a/arch/arm/Kconfig > > > +++ b/arch/arm/Kconfig > > > @@ -1417,7 +1417,7 @@ config BL_SWITCHER > > > bool "big.LITTLE switcher support" > > > depends on BIG_LITTLE && MCPM && HOTPLUG_CPU > > > select ARM_CPU_SUSPEND > > > - select CPU_PM > > > + select CPU_PM if (SUSPEND || CPU_IDLE) > > > > NAK. You just broke the code by doing this. CPU_PM is a requirement > > here. The dependencies for CPU_PM is lacking. > > Is there any real technical reason that CPU_PM depends on SUSPEND || > CPU_IDLE ? If not, those dependencies should be killed.
Those dependencies look artificial to me. Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
