Pranith Kumar <[email protected]> wrote: > loop != call->acks_head || stop; > loop = (loop + 1) & (call->acks_winsz - 1) > ) { > - p_txb = call->acks_window + loop; > - smp_read_barrier_depends(); > + p_txb = lockless_dereference(call)->acks_window + loop;
Nack. You've stuck an implicit barrier on a dereference that doesn't matter. And similar for other hunks of this patch. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
