From: Cyrille Pitchen [... > > It will probably add a lot of object code and, depending on how often > > the registers are accesses, might have performance impact. > > > > Having: > > #define GEM_ISR(n) (0x400 + (n) << 4) > > will save source code. > > > > David > > > > > > > So you suggest that we keep the unsigned int fields ISR, IMR, IER, IDR, TBQP > in > the struct macb_queue and initialize them once for all in macb_probe() like > patch v2 does but only replace the GEM_ISR1 .. GEM_ISR7 defines by GEM_ISR(n) > in macb.h? > > This way there would be to test at run time and we can handle the special > register mapping of queue0. > > Is it what you meant?
In one word, yes. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/