On Fri, Dec 19, 2014 at 9:31 AM, David Miller <[email protected]> wrote: > From: Feng Kan <[email protected]> > Date: Thu, 18 Dec 2014 15:39:51 -0800 > >> +#define NO_MAC_FOUND 0 >> +#define RES_ENET_CSR 0 >> +#define RES_RING_CSR 1 >> +#define RES_RING_CMD 2 Is there a issue with the RES defines, do you prefer enum types?
> > Don't define your own magic set of error return semantics. > > For example, in the MAC address acquisition case, just verify that > you get an ETH_ALEN length value from the fetch routines and return > -ENODEV or similar if you do not. Thanks, well change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
