On Wed, Dec 31, 2014 at 04:04:03AM -0500, Nicholas Mc Guire wrote: > This is only removing the comment which is misleading as > wait_for_completion_timeout does not return < 0 thus there > never is anything to be passed on.
a small doubt - i am seeing that: unsigned long wait_for_completion_timeout() is calling long wait_for_common() which is again calling long __wait_for_common which is again calling long do_wait_for_common() now the return value from do_wait_for_common can be -ERESTARTSYS, so then what happens when wait_for_completion_timeout return this -ERESTARTSYS as an unsigned value ? it becomes a positive value, and ultimately ctx.result (which is 0) is returned. so then are we just ignoring the error value from do_wait_for_common() ? sudip > > patch is against linux-next 3.19.0-rc1 -next-20141226 > > Signed-off-by: Nicholas Mc Guire <[email protected]> > --- > drivers/net/wimax/i2400m/driver.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wimax/i2400m/driver.c > b/drivers/net/wimax/i2400m/driver.c > index 9c78090..0a6384e 100644 > --- a/drivers/net/wimax/i2400m/driver.c > +++ b/drivers/net/wimax/i2400m/driver.c > @@ -197,7 +197,6 @@ int i2400m_op_reset(struct wimax_dev *wimax_dev) > result = -ETIMEDOUT; > else if (result > 0) > result = ctx.result; > - /* if result < 0, pass it on */ > mutex_lock(&i2400m->init_mutex); > i2400m->reset_ctx = NULL; > mutex_unlock(&i2400m->init_mutex); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
