On Sun, Jan 11, 2015 at 1:35 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Sun, 2015-01-11 at 13:01 -0500, Christoph Jaeger wrote: >> Due to a misplaced parenthesis, the expression >> >> (unlikely(offset) < 0), >> >> which expands to >> >> (__builtin_expect(!!(offset), 0) < 0), >> >> never evaluates to true. Therefore, when sending packets with >> PF_PACKET/SOCK_DGRAM, packet_snd() does not abort as intended >> if the creation of the layer 2 header fails. >> >> Spotted by Coverity - CID 1259975 ("Operands don't affect result"). >> >> Fixes: 9c7077622dd9 ("packet: make packet_snd fail on len smaller than l2 >> header") >> Signed-off-by: Christoph Jaeger <c...@linux.com> >> --- > > Nice catch ! > > Acked-by: Eric Dumazet <eduma...@google.com> >
Indeed. I'm responsible for that typo. Thanks a lot for catching it! Acked-by: Willem de Bruijn <will...@google.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/