On Fri, Jan 30, 2015 at 08:43:07AM +0800, kbuild test robot wrote:
> kernel/sched/idle.c:184:1: sparse: symbol '__pcpu_scope_cpu_dead_idle' was
> not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <[email protected]>
It cannot be static, as it is used in kernel/cpu.c. But it sounds like
sparse would be happier if the DECLARE_PER_CPU() was visible in
kernel/sched/idle.c. Which would allow the compiler to catch certain
kinds of typos, now that I think about it.
Or am I missing something here?
Thanx, Paul
> ---
> idle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
> index 42b5102..41354cd 100644
> --- a/kernel/sched/idle.c
> +++ b/kernel/sched/idle.c
> @@ -181,7 +181,7 @@ exit_idle:
> start_critical_timings();
> }
>
> -DEFINE_PER_CPU(bool, cpu_dead_idle);
> +static DEFINE_PER_CPU(bool, cpu_dead_idle);
>
> /*
> * Generic idle loop implementation
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
